Skip to content

Stdlib examples: Produce Exchange WIP#232

Merged
matthewhammer merged 3 commits intostdlibfrom
stdlib-examples
Mar 12, 2019
Merged

Stdlib examples: Produce Exchange WIP#232
matthewhammer merged 3 commits intostdlibfrom
stdlib-examples

Conversation

@matthewhammer
Copy link
Contributor

The Produce Exchange is functional spec, a prototype design, and a WIP Dapp to drive the development of DFINITY, ActorScript, and the standard library of ActorScript.

This PR is a WIP implementation of the Produce Exchange in ActorScript, including whatever standard library features are needed along the way.

@nomeata
Copy link
Contributor

nomeata commented Mar 12, 2019

I am always confused when someone has a PR that is marked as “WIP”, but then an explicit review is requested. Do you just want to ping us? Then saying @matthewhammer should be sufficient (I am subscribed to the whole repository anyways). Or is this an indication that the PR is done so far and ready for review, but the title was just not updated?

@matthewhammer
Copy link
Contributor Author

Good questions.

I guess I want everyone to read this code, eventually. It's not urgent though. It's showing stuff that I want to discuss in the meeting today, and in future meetings.

It doesn't need to be master yet, though, so thus I included the "WIP" acronym.

I could have written this earlier to make this all clear; sorry.

standard.

Outside the PES, are the implementation details of this actor, which
are also present in this file. By virtual of the actor interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virtual -> virtue

@matthewhammer matthewhammer changed the base branch from master to stdlib March 12, 2019 15:54
@matthewhammer matthewhammer merged commit 4332240 into stdlib Mar 12, 2019
@paulyoung
Copy link
Contributor

GitHub allows draft PRs now :) https://github.blog/2019-02-14-introducing-draft-pull-requests/

dfinity-bot added a commit that referenced this pull request Mar 12, 2021
## Changelog for motoko-base:
Branch: next-moc
Commits: [caffeinelabs/motoko-base@25c152b0...5e04f327](caffeinelabs/motoko-base@25c152b...5e04f32)

* [`b33b1dbc`](caffeinelabs/motoko-base@b33b1db) CI: Use motoko 0.5.10
* [`06e4338e`](caffeinelabs/motoko-base@06e4338) Avoid warning M0155 about Nat subtraction ([dfinity/motoko-base⁠#232](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/motoko-base/issues/232))
mergify bot pushed a commit that referenced this pull request Mar 12, 2021
## Changelog for motoko-base:
Branch: next-moc
Commits: [caffeinelabs/motoko-base@25c152b0...5e04f327](caffeinelabs/motoko-base@25c152b...5e04f32)

* [`b33b1dbc`](caffeinelabs/motoko-base@b33b1db) CI: Use motoko 0.5.10
* [`06e4338e`](caffeinelabs/motoko-base@06e4338) Avoid warning M0155 about Nat subtraction ([dfinity/motoko-base⁠#232](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/motoko-base/issues/232))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants