Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While breaking a block in survival mode, the arm does not swing, no breaking particles, and block cracks is not updated #960

Closed
Dasciam opened this issue Dec 15, 2024 · 3 comments
Closed

While breaking a block in survival mode, the arm does not swing, no breaking particles, and block cracks is not updated #960

Dasciam opened this issue Dec 15, 2024 · 3 comments
Labels
blocking This needs to be resolved before release bug Something isn't working
Milestone
v0.10.0

Comments

@Dasciam
Copy link
Contributor

Dasciam commented Dec 15, 2024

Player.ContinueBreaking is never called

The reason is that the code never gets to that point:

dragonfly/server/session/handler_player_action.go

Line 60 in 8dfffe5

c.ContinueBreaking(cube.Face(face))

@Sandertv
Copy link
Member

It looks like the client no longer sends the PlayerActionCrackBreak flag. Does anyone know if this has been reported on other server softwares?

@Sandertv Sandertv added the bug Something isn't working label Dec 15, 2024
@Sandertv Sandertv added this to the v0.10.0 milestone Dec 15, 2024
@Dasciam
Copy link
Contributor Author

Dasciam commented Dec 16, 2024

It looks like the client no longer sends the PlayerActionCrackBreak flag. Does anyone know if this has been reported on other server softwares?

As far as I know, others haven't handled it

@Sandertv
Copy link
Member

PocketMine seems to handle it the same way. Does anyone know if they experience the same issue?

@Sandertv Sandertv added blocking This needs to be resolved before release and removed blocking This needs to be resolved before release labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking This needs to be resolved before release bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@Sandertv @Dasciam