Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow no secret for static public clients #1701

Merged
merged 1 commit into from
May 12, 2020
Merged

allow no secret for static public clients #1701

merged 1 commit into from
May 12, 2020

Conversation

tkleczek
Copy link
Contributor

@tkleczek tkleczek commented May 5, 2020

For statically-configured public clients it should be allowed for both
Secret and SecretEnv fields to be empty.

@tkleczek
allow no secret for static public clients
c830d49 
For statically-configured public clients it should be allowed for both
Secret and SecretEnv fields to be empty.
@tkleczek
Copy link
Contributor Author

tkleczek commented May 5, 2020

This is fix for #1695

srenatus
srenatus approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😃

@sagikazarmark sagikazarmark linked an issue May 12, 2020 that may be closed by this pull request
Secret field is unnecessary required for a static client config. #1695
Closed
sagikazarmark
sagikazarmark approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sagikazarmark sagikazarmark merged commit 336e284 into dexidp:master May 12, 2020
@jenting jenting mentioned this pull request Jun 23, 2020
Merged
@tkleczek tkleczek deleted the static_client_secret_fix branch September 17, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

@srenatus srenatus srenatus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secret field is unnecessary required for a static client config.
3 participants
@tkleczek @srenatus @sagikazarmark