Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: add groups scope by default when filtering is requested #1520

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

bonifaido
Copy link
Member

Fixes: #1518

@bonifaido bonifaido force-pushed the gitlab-groups-scope branch from da3b9c5 to ef08ad8 Compare August 14, 2019 11:33
@bonifaido bonifaido self-assigned this Aug 14, 2019
@bonifaido bonifaido requested a review from srenatus August 14, 2019 13:26
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs documentation, I believe. Can you add a note to the config comments for this connector? Also, I think it might be a bit misleading if this logic only applies to the gitlab connector. The other similarly whitelisting connectors don't do this, do they?

IMHO that's another small argument for moving any group-related filtering out of the connectors and into the server handler 🤔

@bonifaido
Copy link
Member Author

I think now it works like as it should by default, this is the way as the github and bitbucket connectors work. They all add the group scope by default if the whitelisting/filtering is requested, this was missing from gitlab.

Adding this to the server handler would have its benefits, but GitHub connector which supports teams as well is an outlier in this case and I haven't checked the others.

@srenatus
Copy link
Contributor

srenatus commented Sep 4, 2019

They all add the group scope by default if the whitelisting/filtering is requested, this was missing from gitlab.

Ah. I wasn't aware of this. Thanks.

@srenatus srenatus merged commit 3b7292a into master Sep 4, 2019
@srenatus srenatus deleted the gitlab-groups-scope branch September 4, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication through Gitlab
2 participants