Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mishandling of OAuth2 basic auth due to old golang.org/x/oauth2 #1406

Closed
cehoffman opened this issue Feb 17, 2019 · 1 comment
Closed

Mishandling of OAuth2 basic auth due to old golang.org/x/oauth2 #1406

cehoffman opened this issue Feb 17, 2019 · 1 comment

Comments

@cehoffman
Copy link

The golang.org/x/oauth2 dependency was incorrectly handling basic auth encoding of client id and secret. This was fixed in golang/oauth2@13449ad. This bug presents as some confusion among OIDC configurations because of the basic auth unsupported flag. It is framed as being a bug on the providers side when in reality is a bug in dex via the oauth2 library. This causes inconsistency when communicating idP configuration to other installers.
@ericchiang ericchiang mentioned this issue Feb 22, 2019
Closed
@srenatus
Copy link
Contributor

#1501 ✔️ should be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go.mod: update all vendored code with 'go get -u' ericchiang/dex
2 participants
@cehoffman @srenatus