Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Implicit OIDC flow for the OIDC connector #1254

Open
colemickens opened this issue Jun 24, 2018 · 5 comments
Open

Support Implicit OIDC flow for the OIDC connector #1254

colemickens opened this issue Jun 24, 2018 · 5 comments

Comments

@colemickens
Copy link

I know that Dex supports the implicit flow for the IdP, but I'd like to be able to use Dex with Portier, which only supports response_type=id_token and the grant_type=implicit.

Unfortunately, this requires tracking the nonce (which is required in the implicit flow) whereas the current OIDC connector seems stateless during the initial exchange.

Is there a pattern to follow here? Maybe a connector that has to stash some session data during the authentication flow? Is there a way to "start" the identity without it being treated as fully authenticated?

@colemickens
Copy link
Author

Hm, it looks like the server does maintain an authrequest for outbound oidc-alike connectors but handles the storage on behalf of the connector. I'll see if there's a way to support nonce without needing to refactor how storage is handled.

@colemickens
Copy link
Author

I have this implemented in a fork by adding ConnectorData that can be persisted/accessed during the flow. But it's blocked on #1255.

@srenatus
Copy link
Contributor

srenatus commented Sep 3, 2018

@colemickens Any update on this? It looks like #1255 isn't blocking this anymore.

@colemickens
Copy link
Author

I had implemented it here. It stacks on another PR that isn't merged yet, though. #1256

@srenatus
Copy link
Contributor

srenatus commented Sep 3, 2018

Sorry, sifting through so many issues and PRs. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants