Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move redux-saga to peerDependencies? #72

Open
prontiol opened this issue Apr 19, 2018 · 1 comment
Open

Move redux-saga to peerDependencies? #72

prontiol opened this issue Apr 19, 2018 · 1 comment

Comments

@prontiol
Copy link

I just noticed that redux-crud-store has redux-saga in dependencies section, but users have to have redux-saga in their project in order to use this package, so why not to put it to peerDependencies saving some bytes in the bundle?
@devvmh
Copy link
Owner

devvmh commented Apr 20, 2018

Hey sounds like a plan!

Would you be willing to test this locally and submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devvmh @prontiol