Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

632 dynamic tab investigation #707

Closed
wants to merge 4 commits into from
Closed

Conversation

Dammshine
Copy link
Contributor

No description provided.

@Dammshine Dammshine linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link
Contributor

@NE1NN NE1NN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dqna64 dqna64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these packages being used

(currentPos - startPos) / (isHorizontal ? window.innerWidth : window.innerHeight);
const ratioAfterMouseDown = [...ratioBeforeMouseDown];

// TODO: THIS IS IMPORTANT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what needs to be done here

@Dammshine Dammshine closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Tab Investigation
4 participants