Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar toggle button position can be improved for better user experience #353

Open
PAVAN507-STAR opened this issue Jan 17, 2025 · 5 comments
Assignees

Comments

@PAVAN507-STAR
Copy link

PAVAN507-STAR commented Jan 17, 2025

Currently toggling on/off the side bar is not so optimal in user's pov as the pos of the toggling button shifts position on toggle,it can be changed to something similar what most other websites generally use where the position kindof remains same.I've attached the images below for reference(Btw it's my first time contributing here,so guide me if I'm wrong).If it's okay I would like to work on it as it looks like a good first issue. @wurstbrot

from this
Image

To

Image
@PAVAN507-STAR
Copy link
Author

PAVAN507-STAR commented Jan 18, 2025

@wurstbrot If it's okay can i work on this issue or let me know if there's something else I can contribute .

@wurstbrot
Copy link
Collaborator

wurstbrot commented Jan 18, 2025

Hi @PAVAN507-STAR ,

sure. We are very happy about contributions as a PR. Create a PR and @0x41head and I will guide you if something is missing.

As DSOMM is a security related project, in the best case, you sign your commits.

Regarding this feature: You want to move the burger button left/right of the logo dsomm?

@PAVAN507-STAR
Copy link
Author

@wurstbrot yeah sure i'll start working on it.I think it would be better to move the burger to left of the logo dsomm as it is the initial position before toggle(as in the example of youtube)

@vbakke
Copy link
Contributor

vbakke commented Jan 18, 2025

Excellent, @PAVAN507-STAR .

Just to let you know, I've started looking at making DSOMM a bit more responsive in an experimental branch (https://dsomm.pages.dev/). I just haven't had time to merge it, as I've stumbled over other issues that I have prioritised.

It would be great if we could join forces. Maybe together a roadmap with Wurstbrot.

@PAVAN507-STAR
Copy link
Author

Excellent, @PAVAN507-STAR .

Just to let you know, I've started looking at making DSOMM a bit more responsive in an experimental branch (https://dsomm.pages.dev/). I just haven't had time to merge it, as I've stumbled over other issues that I have prioritised.

It would be great if we could join forces. Maybe together a roadmap with Wurstbrot.

Yeah sure.Can you connect with me on twitter.(or any other social handles) or slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants