Implement translations from old event types to new ones #99

radovanjorgic · 2025-11-12T14:21:55Z

Description

Migrated event type names from old E2DR to DR2E naming convention.
Added a simple function for easier translation and migration.

Connected Issues

#ISS-131089

Checklist

Tests added/updated and ran with npm run test OR no tests needed.
Ran backwards compatibility tests with npm run test:backwards-compatibility.
Code formatted and checked with npm run lint.
Tested airdrop-template linked to this PR.
Documentation updated and provided a link to PR / new docs OR no docs needed.

src/tests/timeout-handling/timeout-3a.test.ts

src/tests/timeout-handling/timeout-2.test.ts

src/tests/timeout-handling/timeout-1.test.ts

src/common/helpers.ts

src/tests/timeout-handling/timeout-3b.test.ts

src/common/event-type-normalization.ts

radovanjorgic

Update PR title to something understandable to 3P developers (old to new event types instead of E2DR to DR2E). Please verify this works on template, asana and maybe even release one beta version so other connectors can test if their connectors still work. I would be super careful with merging this.

src/common/control-protocol.ts

src/common/event-type-normalization.ts

src/tests/timeout-handling/timeout-1.test.ts

src/types/extraction.ts

src/types/workers.ts

src/workers/spawn.ts

… inside of spawn.

radovanjorgic

Much better, few nits.

src/types/workers.ts

src/workers/default-workers/load-attachments.ts

src/workers/process-task.ts

src/workers/spawn.ts

…anslated'.

gasperzgonec · 2025-11-27T11:43:36Z

src/workers/spawn.ts

+function getCallerDirectory(): string {
+  const originalPrepareStackTrace = Error.prepareStackTrace;
+
+  Error.prepareStackTrace = (_, stack) => stack;
+  const err = new Error();
+  Error.captureStackTrace(err);
+  const stack = err.stack as unknown as NodeJS.CallSite[];
+  Error.prepareStackTrace = originalPrepareStackTrace;
+
+  // Iterate through the stack to find the first file that's not part of the SDK
+  for (const callSite of stack) {
+    const filename = callSite.getFileName();
+    if (
+      filename &&
+      !filename.includes('@devrev/ts-adaas') &&
+      !filename.includes('adaas-sdk')
+    ) {
+      return path.dirname(filename);
+    }
  }
-  return path;
+
+  // Fallback to __dirname if we can't determine the caller
+  return __dirname;


I have had to reimplement the automatic detection of the directory the spawn is being called from.
This works by reading the callstack and navigating up just far enough to get out of the SDK.

This might not be perfect and it could fail on some edge-cases (that I was unable to think of), but it has been tested both locally and in Lambda.

If we override the getWorker, that will be appended to the path where we called spawn, if it's not provided, the pre-defined paths will be appended to the path.

TBH I don't like this. This way of stack inspection seems pretty fragile and unreliable to me. I have a feeling it might break with bundlers, if the package name differs and so on. Also, this is pretty non-standard approach for JavaScript.

On the other side, I think there won't be many cases where users want to override those paths, so can we rather require user to pass baseDirectory in the options alongside with workerPathOverridings. What is __dirname in this case?

I have replaced it with a field in spawn, that allows user to pass in the current script directory.

radovanjorgic · 2025-11-28T10:47:21Z

src/common/event-type-translation.ts

+    [EventType.UnknownEventType]: EventType.UnknownEventType,
+  };
+
+  const normalized = eventTypeMap[eventTypeString];


Use translated instead normalized all over the code

radovanjorgic · 2025-11-28T10:48:42Z

src/types/workers.ts

  isLocalDevelopment?: boolean;
  timeout?: number;
  batchSize?: number;
+  workerPathOverrides?: Partial<Record<EventType, string>>;


We still use Partial here and don't have separate interface for this?

radovanjorgic · 2025-11-28T10:49:17Z

src/types/workers.ts

 export interface GetWorkerPathInterface {
  event: AirdropEvent;
  connectorWorkerPath?: string | null;
+  callerDir?: string | null;


Document this a bit through JSDoc please, what is callerDir?

radovanjorgic · 2025-11-28T11:27:28Z

src/workers/spawn.ts

+function getCallerDirectory(): string {
+  const originalPrepareStackTrace = Error.prepareStackTrace;
+
+  Error.prepareStackTrace = (_, stack) => stack;
+  const err = new Error();
+  Error.captureStackTrace(err);
+  const stack = err.stack as unknown as NodeJS.CallSite[];
+  Error.prepareStackTrace = originalPrepareStackTrace;
+
+  // Iterate through the stack to find the first file that's not part of the SDK
+  for (const callSite of stack) {
+    const filename = callSite.getFileName();
+    if (
+      filename &&
+      !filename.includes('@devrev/ts-adaas') &&
+      !filename.includes('adaas-sdk')
+    ) {
+      return path.dirname(filename);
+    }
  }
-  return path;
+
+  // Fallback to __dirname if we can't determine the caller
+  return __dirname;


TBH I don't like this. This way of stack inspection seems pretty fragile and unreliable to me. I have a feeling it might break with bundlers, if the package name differs and so on. Also, this is pretty non-standard approach for JavaScript.

On the other side, I think there won't be many cases where users want to override those paths, so can we rather require user to pass baseDirectory in the options alongside with workerPathOverridings. What is __dirname in this case?

radovanjorgic requested review from a team and gasperzgonec as code owners November 12, 2025 14:21

radovanjorgic marked this pull request as draft November 12, 2025 14:21

gasperzgonec requested changes Nov 13, 2025

View reviewed changes

gasperzgonec force-pushed the rado/event-renamings-poc branch 4 times, most recently from db603ae to f462b19 Compare November 18, 2025 08:56

gasperzgonec marked this pull request as ready for review November 18, 2025 08:58

gasperzgonec changed the title ~~Event renamings with normalization functions~~ Implement translations from E2DR to DR2E Nov 18, 2025

radovanjorgic commented Nov 19, 2025

View reviewed changes

gasperzgonec changed the title ~~Implement translations from E2DR to DR2E~~ Implement translations from old event types to new ones Nov 24, 2025

radovanjorgic and others added 9 commits November 24, 2025 15:17

Event renamings with normalization functions

a82bb0b

Removed redundant default workers and added default paths for workers…

165c9fd

… inside of spawn.

Updated deprecated adapter to ensure compatibility.

bc0ddc5

Apply suggestions from code review

5c491c1

Deduplicated the strings used for keys

b1210f4

Ran a linter and prettier

a5d2244

Satisfied linter and fixed backward-compatibility tests.

c8a0354

Fixed nits.

630d0bf

Renamed remaining normalizations to translations.

de2c3cd

gasperzgonec force-pushed the rado/event-renamings-poc branch from 37917c2 to de2c3cd Compare November 24, 2025 14:17

gasperzgonec self-requested a review November 24, 2025 14:21

gasperzgonec approved these changes Nov 24, 2025

View reviewed changes

gasperzgonec self-assigned this Nov 25, 2025

radovanjorgic commented Nov 25, 2025

View reviewed changes

gasperzgonec and others added 3 commits November 25, 2025 15:18

Removed default workers, added a TODO and renamed 'normalized' to 'tr…

50febc8

…anslated'.

Fixed the path overrides for getWorkerPath.

a8ceca9

chore: release v1.12.3-beta.0

ef82227

gasperzgonec force-pushed the rado/event-renamings-poc branch from ef82227 to 0fc8fe0 Compare November 27, 2025 11:12

Removed 'node_modules' skipping.

d307312

gasperzgonec force-pushed the rado/event-renamings-poc branch from 0fc8fe0 to d307312 Compare November 27, 2025 11:13

chore: release v1.12.3-beta.1

bf268cd

gasperzgonec reviewed Nov 27, 2025

View reviewed changes

Merge branch 'main' into rado/event-renamings-poc

89312dc

radovanjorgic commented Nov 28, 2025

View reviewed changes

gasperzgonec added 2 commits November 28, 2025 14:51

Removed the CallStack traversal and changed for user-provided path.

e1120ae

Fixed translations and changed GetWorkerPathInterface.

51a0f03

Implement translations from old event types to new ones #99

Are you sure you want to change the base?

Implement translations from old event types to new ones #99

Uh oh!

Conversation

radovanjorgic commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Connected Issues

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radovanjorgic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radovanjorgic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gasperzgonec Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

radovanjorgic Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

gasperzgonec Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

radovanjorgic Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

radovanjorgic Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

radovanjorgic Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

radovanjorgic Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

radovanjorgic commented Nov 12, 2025 •

edited

Loading