Fixed nits.

Author: gasperzgonec

src/common/control-protocol.ts

@@ -23,10 +23,11 @@ export const emit = async ({
   data,
 }: EmitInterface): Promise<AxiosResponse> => {
   // Normalize outgoing event type to ensure we always send new event types
-  const normalizedEventType = normalizeOutgoingEventType(eventType);
+  // TODO: Remove when the old types are completely phased out
+  const translatedEventType = normalizeOutgoingEventType(eventType);
 
   const newEvent: ExtractorEvent | LoaderEvent = {
-    event_type: normalizedEventType,
+    event_type: translatedEventType,
     event_context: event.payload.event_context,
     event_data: {
       ...data,

src/tests/timeout-handling/timeout-1.test.ts

@@ -1,4 +1,4 @@
-import { EventType } from '../../types/extraction';
+import { EventType, ExtractorEventType } from '../../types/extraction';
 import { MockServer } from '../mock-server';
 import { createEvent } from '../test-helpers';
 import run from './extraction';
@@ -43,6 +43,6 @@ describe('timeout-1 extraction', () => {
     // Expect last request to be emission of done event
     expect(lastRequest.url).toContain('airdrop.external-extractor.message');
     expect(lastRequest.method).toBe('POST');
-    expect(lastRequest.body.event_type).toBe('DATA_EXTRACTION_DONE');
+    expect(lastRequest.body.event_type).toBe(ExtractorEventType.DataExtractionDone);
   });
 });

src/tests/timeout-handling/timeout-2.test.ts

@@ -1,4 +1,4 @@
-import { EventType } from '../../types/extraction';
+import { EventType, ExtractorEventType } from '../../types/extraction';
 import { MockServer } from '../mock-server';
 import { createEvent } from '../test-helpers';
 import run from './extraction';
@@ -45,6 +45,6 @@ describe('timeout-2 extraction', () => {
     // Expect last request to be emission of progress event
     expect(lastRequest.url).toContain('airdrop.external-extractor.message');
     expect(lastRequest.method).toBe('POST');
-    expect(lastRequest.body.event_type).toBe('DATA_EXTRACTION_PROGRESS');
+    expect(lastRequest.body.event_type).toBe(ExtractorEventType.DataExtractionProgress);
   });
 });

src/tests/timeout-handling/timeout-3a.test.ts

@@ -1,4 +1,4 @@
-import { EventType } from '../../types/extraction';
+import { EventType, ExtractorEventType } from '../../types/extraction';
 import { MockServer } from '../mock-server';
 import { createEvent } from '../test-helpers';
 import run from './extraction';
@@ -45,6 +45,6 @@ describe('timeout-3a extraction', () => {
     // Expect last request to be emission of error event since we force-kill the worker
     expect(lastRequest.url).toContain('airdrop.external-extractor.message');
     expect(lastRequest.method).toBe('POST');
-    expect(lastRequest.body.event_type).toBe('DATA_EXTRACTION_ERROR');
+    expect(lastRequest.body.event_type).toBe(ExtractorEventType.DataExtractionError);
   });
 });

src/tests/timeout-handling/timeout-3b.test.ts

@@ -1,4 +1,4 @@
-import { EventType } from '../../types/extraction';
+import { EventType, ExtractorEventType } from '../../types/extraction';
 import { MockServer } from '../mock-server';
 import { createEvent } from '../test-helpers';
 import run from './extraction';
@@ -45,6 +45,6 @@ describe('timeout-3b extraction', () => {
     // Expect last request to be emission of progress event
     expect(lastRequest.url).toContain('airdrop.external-extractor.message');
     expect(lastRequest.method).toBe('POST');
-    expect(lastRequest.body.event_type).toBe('DATA_EXTRACTION_PROGRESS');
+    expect(lastRequest.body.event_type).toBe(ExtractorEventType.DataExtractionProgress);
   });
 });

src/types/workers.ts

@@ -30,13 +30,13 @@ export interface WorkerAdapterInterface<ConnectorState> {
  * @param {boolean=} isLocalDevelopment - A flag to indicate if the adapter is being used in local development
  * @param {number=} timeout - The timeout for the worker thread
  * @param {number=} batchSize - Maximum number of extracted items in a batch
- * @param {Partial<Record<EventType, string>>=} worker_path_overrides - A map of event types to custom worker paths to override default worker paths
+ * @param {Record<EventType, string>=} worker_path_overrides - A map of event types to custom worker paths to override default worker paths
  */
 export interface WorkerAdapterOptions {
   isLocalDevelopment?: boolean;
   timeout?: number;
   batchSize?: number;
-  worker_path_overrides?: Partial<Record<EventType, string>>;
+  workerPathOverrides?: Record<EventType, string>;
 }
 
 /**

src/workers/spawn.ts

@@ -133,16 +133,16 @@ export async function spawn<ConnectorState>({
   // Normalize incoming event type for backwards compatibility
   // This allows the SDK to accept both old and new event type formats
   const originalEventType = event.payload.event_type;
-  const normalizedEventType = normalizeIncomingEventType(
+  const translatedEventType = normalizeIncomingEventType(
     event.payload.event_type as string
   );
 
   // Update the event with the normalized event type
-  event.payload.event_type = normalizedEventType;
+  event.payload.event_type = translatedEventType;
 
-  if (normalizedEventType !== originalEventType) {
+  if (translatedEventType !== originalEventType) {
     console.log(
-      `Event type normalized from ${originalEventType} to ${normalizedEventType}`
+      `Event type normalized from ${originalEventType} to ${translatedEventType}.`
     );
   }
 
@@ -165,10 +165,10 @@ export async function spawn<ConnectorState>({
 
   let script = null;
   if (
-    options?.worker_path_overrides &&
-    options.worker_path_overrides[normalizedEventType as EventType]
+    options?.workerPathOverrides &&
+    options.workerPathOverrides[translatedEventType as EventType]
   ) {
-    script = options.worker_path_overrides[normalizedEventType as EventType];
+    script = options.workerPathOverrides[translatedEventType as EventType];
   } else {
     script = getWorkerPath({
       event,