Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A "timeout" parameter would be nice #219

Open
viktorbenei opened this issue Nov 17, 2015 · 2 comments
Open

A "timeout" parameter would be nice #219

viktorbenei opened this issue Nov 17, 2015 · 2 comments

Comments

@viktorbenei
Copy link

Sometimes, especially with larger DigitalOcean droplets/snapshots the rebuild and other actions might time out before the DO droplet would be ready.

A simple, optional parameter would be nice, to be able to increase the timeout.

Related code: https://github.com/smdahlen/vagrant-digitalocean/blob/d2b2b729ea676f1b1c1d17651fba3081f495423c/lib/vagrant-digitalocean/helpers/client.rb#L91 - right now the retry count & sleep times are hardcoded, at least the retry count could be exposed as a configuration option.

Context: we started to hit frequent timeouts today, sent a ticket to DO and they replied that for larger droplets created from snapshots the create&re-build actions might actually take longer than the hardcoded limit in this plugin.

@seth-reeser
Copy link
Member

Thank you for your feedback. 120 retries times 10 seconds sleep = 1200 seconds / 60 = 20 minutes.. How long are you proposing?

@viktorbenei
Copy link
Author

I think that's good for a default value, actually less than 20 mins should be enough; but there might be a case when someone have to modify the timeout to fit their needs. IMO it would be good to have a configuration option for this.

That said, we're no longer using DigitalOcean, specifically because of the long boot times of custom/snapshot based VMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants