Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix embedding of PDFs on talk page #6542

Open
mattstratton opened this issue Aug 31, 2018 · 5 comments
Open

fix embedding of PDFs on talk page #6542

mattstratton opened this issue Aug 31, 2018 · 5 comments

Comments

@mattstratton
Copy link
Member

I'm not 100% sure if this ever worked (I didn't write the code for this) but on the shown example, the PDF viewer bumps into the sponsor row, and it is not usable.

image

mattstratton referenced this issue Aug 31, 2018
mattstratton referenced this issue Sep 1, 2018
* Add slides for Sonia talk

* Add PDF link for Quin's slides

* Change from PDF to Slides in frontmatter

There's a defect in the theme where the PDF viewer runs into the sponsor row

https://github.com/devopsdays/devopsdays-theme/issues/646

* Add link to Donovan's slides

* Add Tiffany's slides

* Add tweet from Donovan's talk
@bridgetkromhout
Copy link
Collaborator

bridgetkromhout commented Sep 8, 2018

I see this happening on a Minneapolis 2017 talk and I'm pretty sure it was not happening when I updated the site at the time: https://www.devopsdays.org/events/2017-minneapolis/program/kristen-womack/

Let’s look at how to use system data to uncover the deeper story of your product, to understand what users want without asking them and without guessing. Focusing on the ‘learn’ aspect of the build-measure-learn development cycle, let’s make better use of system logs and other data to inform what we build. Think of it as bringing a deeper connection between roadmaps and a DevOps culture.

@bridgetkromhout
Copy link
Collaborator

Hmm, I checked with $ git checkout 7086b38072501e49d3a83b9ec8c5280ee53c5b91 and apparently it was happening at the time, and I either didn't notice or didn't prioritize it.

@mattstratton mattstratton transferred this issue from devopsdays/devopsdays-theme Mar 11, 2019
@bridgetkromhout
Copy link
Collaborator

This is fixed in #8076 for cases of a simple-to-embed PDF. We have a corner case, it appears, if the PDF is in a github repo - github appears to block such an embed (see https://github.com/github/markup#github-markup).

@bridgetkromhout bridgetkromhout changed the title PDF on talk page can run into sponsor row fix embedding of PDFs on talk page Aug 29, 2019
@mattstratton
Copy link
Member Author

If github blocks embedding, I don’t see how we can code around it. This seems like a documentation update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants