-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix embedding of PDFs on talk page #6542
Comments
There's a defect in the theme where the PDF viewer runs into the sponsor row https://github.com/devopsdays/devopsdays-theme/issues/646
* Add slides for Sonia talk * Add PDF link for Quin's slides * Change from PDF to Slides in frontmatter There's a defect in the theme where the PDF viewer runs into the sponsor row https://github.com/devopsdays/devopsdays-theme/issues/646 * Add link to Donovan's slides * Add Tiffany's slides * Add tweet from Donovan's talk
I see this happening on a Minneapolis 2017 talk and I'm pretty sure it was not happening when I updated the site at the time: https://www.devopsdays.org/events/2017-minneapolis/program/kristen-womack/
|
Hmm, I checked with |
This is fixed in #8076 for cases of a simple-to-embed PDF. We have a corner case, it appears, if the PDF is in a github repo - github appears to block such an embed (see https://github.com/github/markup#github-markup). |
test case: content/events/2018-chicago/program/quintessence-anx.md -slides = "https://github.com/quintessence/presentations/blob/master/sensory-friendly-monitoring/sensory-friendly-monitoring.pdf" |
If github blocks embedding, I don’t see how we can code around it. This seems like a documentation update. |
I'm not 100% sure if this ever worked (I didn't write the code for this) but on the shown example, the PDF viewer bumps into the sponsor row, and it is not usable.
The text was updated successfully, but these errors were encountered: