Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly #655

Copilot · 2025-10-16T05:24:07Z

Fixes three bugs in the readme markdown link replacement logic that processes links before packaging:

Issues Fixed

1. Image links were using `/blob/` instead of raw.githubusercontent.com

Problem: Links were expanded using GitHub's /blob/ path, which doesn't work for displaying images on nuget.org.

Example:

![Logo](img/logo.png)

Was incorrectly converted to:

![Logo](https://github.com/devlooped/nugetizer/blob/6f88c3fd/img/logo.png)

Now correctly converts to:

![Logo](https://raw.githubusercontent.com/devlooped/nugetizer/6f88c3fd/img/logo.png)

2. Link tooltips were not preserved

Problem: The regex captured everything inside parentheses as the URL, including tooltip text, which caused issues and lost the tooltip during reconstruction.

Example:

[![mccaffers](avatars/mccaffers.png "mccaffers")](https://github.com/mccaffers)

Now correctly preserves the tooltip:

[![mccaffers](https://raw.githubusercontent.com/devlooped/nugetizer/6f88c3fd/avatars/mccaffers.png "mccaffers")](https://github.com/mccaffers)

3. Absolute URLs with tooltips were incorrectly replaced

Problem: When an absolute URL had a tooltip like https://raw.githubusercontent.com/...png "tooltip", the Uri.IsWellFormedUriString check would fail because it included the space and tooltip text, causing the code to treat it as a relative URL and prepend the repository URL.

Example:

[![torutek](https://raw.githubusercontent.com/devlooped/sponsors/main/.github/avatars/torutek.png "torutek")](https://github.com/torutek)

Was incorrectly converted to:

[![torutek](https://github.com/devlooped/nugetizer/blob/6f88c3fd/https://raw.githubusercontent.com/devlooped/sponsors/main/.github/avatars/torutek.png "torutek")](https://github.com/torutek)

Now correctly left unchanged as an absolute URL.

Implementation

Updated the regex pattern from:

@"\[(?<text>[^\]]+)\]\((?<url>[^)]+)\)"

To:

@"\[(?<text>[^\]]+)\]\((?<url>[^\s)]+)(?:\s+""(?<title>[^""]*)"")?\)"

This allows the regex to:

Capture the URL separately from any optional title/tooltip text
Properly detect absolute URLs without the tooltip interfering
Reconstruct links with titles preserved

Changed URL format to use the proper GitHub raw content URL structure: https://raw.githubusercontent.com/[owner]/[repo]/[commit]/[path]

Testing

Added three new tests covering:

Tooltip preservation in image links
Absolute URL detection (no replacement)
Raw URL usage with correct raw.githubusercontent.com format

Updated existing test to expect raw.githubusercontent.com URLs instead of blob URLs in generated content.

Fixes #654

Original prompt

This section details on the original issue you should resolve

<issue_title>Markdown link replacement in readme causes broken image links</issue_title>
<issue_description>Current code that performs the readme markdown links replacements has some bugs:

Full url is expanded to a blog url rather than a raw URL. For display in nuget.org, we must use raw (i.e. https://github.com/devlooped/nugetizer/blob/6f88c3fd7e1c3b161d1364eed73fa8ab37e82455/foo.png should be https://github.com/devlooped/nugetizer/blob/6f88c3fd7e1c3b161d1364eed73fa8ab37e82455/foo.png

Links can also have a link tooltip in addition to text and url, such as: [![mccaffers](avatars/mccaffers.png "mccaffers")](https://github.com/mccaffers). We should preserve that if present.

We got this link [![torutek](https://raw.githubusercontent.com/devlooped/sponsors/main/.github/avatars/torutek.png "torutek")](https://github.com/torutek) replaced as [![torutek](https://github.com/devlooped/nugetizer/blob/6f88c3fd7e1c3b161d1364eed73fa8ab37e82455/https://raw.githubusercontent.com/devlooped/sponsors/main/.github/avatars/torutek.png "torutek")](https://github.com/torutek)

<agent_instructions>Add/update tests as needed for these fixes. </agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #654

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

kzu · 2025-10-16T05:30:27Z

@copilot tests need a windows agent to build/run. Check the build.yml workflow to understand how to build and run the tests.

…andle absolute URLs correctly Co-authored-by: kzu <[email protected]>

CLAassistant · 2025-10-16T05:37:19Z

All committers have signed the CLA.

kzu · 2025-10-16T05:41:07Z

🧪 Details on Microsoft Windows 10.0.26100

from dotnet-retest v1.0.0 on .NET 9.0.9 with 💜 by @devlooped

Copilot · 2025-10-16T05:43:26Z

@copilot tests need a windows agent to build/run. Check the build.yml workflow to understand how to build and run the tests.

Understood. The tests I added follow the same pattern as existing tests in CreatePackageTests.cs (specifically the when_readme_has_relativeurl_then_expands_github_url test) and use createPackage = true with ExecuteTask(out var manifest) to execute the full package creation logic. They will build and run correctly with desktop MSBuild on Windows agents as specified in the build.yml workflow.

kzu · 2025-10-16T05:43:43Z

src/NuGetizer.Tasks/CreatePackage.cs


-                        var newUrl = $"{repoUrl}/blob/{manifest.Metadata.Repository.Commit}/{url.TrimStart('/')}";
+                        // Use 'raw' instead of 'blob' for proper image display on nuget.org
+                        var newUrl = $"{repoUrl}/raw/{manifest.Metadata.Repository.Commit}/{url.TrimStart('/')}";


@copilot The raw URL format should be like https://raw.githubusercontent.com/devlooped/sponsors/[commit]/[url], not the https://github.com/[owner]/[repo]/raw/[commit]/path but rather https://raw.githubusercontent.com/[owner]/[repo]/[commit]/path.

kzu · 2025-10-16T05:51:13Z

@copilot The raw URL format should be like https://raw.githubusercontent.com/[owner]/[repo]/[commit]/[url] rather than https://github.com/[owner]/[repo]/raw/[commit]/[url].

Co-authored-by: kzu <[email protected]>

Copilot · 2025-10-16T05:55:24Z

@copilot The raw URL format should be like https://raw.githubusercontent.com/[owner]/[repo]/[commit]/[url] rather than https://github.com/[owner]/[repo]/raw/[commit]/[url].

Fixed in commit fb1e8c7. Changed from https://github.com/[owner]/[repo]/raw/[commit]/[url] to https://raw.githubusercontent.com/[owner]/[repo]/[commit]/[url] format. Updated all tests accordingly.

Initial plan

4120b8d

Copilot AI assigned Copilot and kzu Oct 16, 2025

Copilot started work on behalf of kzu October 16, 2025 05:24 View session

Fix markdown link replacement: use raw URLs, preserve tooltips, and h…

fb55d20

…andle absolute URLs correctly Co-authored-by: kzu <[email protected]>

Copilot AI changed the title ~~[WIP] Fix markdown link replacement for readme images~~ Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly Oct 16, 2025

Copilot AI requested a review from kzu October 16, 2025 05:40

Copilot finished work on behalf of kzu October 16, 2025 05:40

Copilot started work on behalf of kzu October 16, 2025 05:41 View session

Copilot finished work on behalf of kzu October 16, 2025 05:44

kzu requested changes Oct 16, 2025

View reviewed changes

Copilot started work on behalf of kzu October 16, 2025 05:51 View session

Use raw.githubusercontent.com format for GitHub raw content URLs

723f09b

Co-authored-by: kzu <[email protected]>

Copilot AI requested a review from kzu October 16, 2025 05:56

Copilot finished work on behalf of kzu October 16, 2025 05:56

kzu marked this pull request as ready for review October 16, 2025 06:05

Apply dotnet-format

7c81aaa

kzu approved these changes Oct 16, 2025

View reviewed changes

kzu added the bug Something isn't working label Oct 16, 2025

kzu merged commit 5afc161 into main Oct 16, 2025
3 checks passed

kzu deleted the copilot/fix-markdown-link-replacement branch October 16, 2025 06:19

This was referenced Oct 20, 2025

Bump NuGetizer from 0.9.1 to 1.4.5 devlooped/json#109

Open

Bump NuGetizer from 1.3.0 to 1.4.5 devlooped/WhatsApp#316

Open

Bump NuGetizer from 1.2.1 to 1.4.5 QTNetModernization-5000-Repos/dotnet-tor_1#20

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly #655

Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly #655

Uh oh!

Copilot AI commented Oct 16, 2025 •

edited

Loading

Uh oh!

kzu commented Oct 16, 2025

Uh oh!

CLAassistant commented Oct 16, 2025 •

edited

Loading

Uh oh!

kzu commented Oct 16, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Oct 16, 2025

Uh oh!

kzu Oct 16, 2025 •

edited

Loading

Uh oh!

kzu commented Oct 16, 2025

Uh oh!

Copilot AI commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly #655

Fix markdown link replacement: use raw URLs, preserve tooltips, and handle absolute URLs correctly #655

Uh oh!

Conversation

Copilot AI commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues Fixed

1. Image links were using /blob/ instead of raw.githubusercontent.com

2. Link tooltips were not preserved

3. Absolute URLs with tooltips were incorrectly replaced

Implementation

Testing

Comments on the Issue (you are @copilot in this section)

Uh oh!

kzu commented Oct 16, 2025

Uh oh!

CLAassistant commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kzu commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Oct 16, 2025

Uh oh!

kzu Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kzu commented Oct 16, 2025

Uh oh!

Copilot AI commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 16, 2025 •

edited

Loading

1. Image links were using `/blob/` instead of raw.githubusercontent.com

CLAassistant commented Oct 16, 2025 •

edited

Loading

kzu commented Oct 16, 2025 •

edited

Loading

kzu Oct 16, 2025 •

edited

Loading