Ensure transitive dependencies are properly resolved for inference #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET 7.0 SDK changed from:
```xml
<ResolvePackageDependencies
ProjectPath="$(MSBuildProjectFullPath)"
ProjectAssetsFile="$(ProjectAssetsFile)"
ProjectLanguage="$(Language)"
EmitLegacyAssetsFileItems="$(EmitLegacyAssetsFileItems)"
TargetFramework="$(TargetFramework)"
ContinueOnError="ErrorAndContinue">
<Output TaskParameter="PackageDefinitions" ItemName="PackageDefinitions" />
<Output TaskParameter="PackageDependencies" ItemName="PackageDependencies" />
<!-- These outputs only produced when EmitLegacyAssetsFileItems is true -->
<Output TaskParameter="TargetDefinitions" ItemName="TargetDefinitions" />
<Output TaskParameter="FileDefinitions" ItemName="FileDefinitions" />
<Output TaskParameter="FileDependencies" ItemName="FileDependencies" />
</ResolvePackageDependencies>
```
to:
```xml
<ResolvePackageDependencies
ProjectPath="$(MSBuildProjectFullPath)"
ProjectAssetsFile="$(ProjectAssetsFile)"
ProjectLanguage="$(Language)"
TargetFramework="$(TargetFramework)"
ContinueOnError="ErrorAndContinue"
Condition="'$(EmitLegacyAssetsFileItems)' == 'true'">
<Output TaskParameter="PackageDefinitions" ItemName="PackageDefinitions" />
<Output TaskParameter="PackageDependencies" ItemName="PackageDependencies" />
<Output TaskParameter="TargetDefinitions" ItemName="TargetDefinitions" />
<Output TaskParameter="FileDefinitions" ItemName="FileDefinitions" />
<Output TaskParameter="FileDependencies" ItemName="FileDependencies" />
</ResolvePackageDependencies>
```
Since the SDK now conditions the execution of the resolve to the value of `EmitLegacyAssetsFileItems`, we need to explicitly set it.
Since this was likely done for performance reasons, only turn on when package inference is active, since we don't use that anywhere else.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 7.0 SDK changed from:
to:
Since the SDK now conditions the execution of the resolve to the value of
EmitLegacyAssetsFileItems, we need to explicitly set it.Since this was likely done for performance reasons, only turn on when package inference is active, since we don't use that anywhere else.