Skip to content

Commit 5eb6b33

Browse files
gitfoolkzu
authored andcommitted
Fix git read cache race condition
Continue on error as same as no cache.
1 parent f12c456 commit 5eb6b33

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/GitInfo/build/GitInfo.targets

+5-5
Original file line numberDiff line numberDiff line change
@@ -384,12 +384,12 @@
384384
<Delete Files="$(_GitInfoFile)" />
385385
</Target>
386386

387-
<Target Name="_GitReadCache" Condition="Exists('$(_GitInfoFile)') And '$(SkipReadGitCache)' != 'true' ">
388-
<PropertyGroup>
389-
<_GitCachedInfo>$([System.IO.File]::ReadAllText('$(_GitInfoFile)'))</_GitCachedInfo>
390-
</PropertyGroup>
387+
<Target Name="_GitReadCache" Condition="Exists('$(_GitInfoFile)') And '$(SkipReadGitCache)' != 'true'">
388+
<ReadLinesFromFile File="$(_GitInfoFile)" ContinueOnError="true">
389+
<Output TaskParameter="Lines" ItemName="_GitCachedInfo" />
390+
</ReadLinesFromFile>
391391

392-
<CreateItem Include="GitInfo" AdditionalMetadata="$(_GitCachedInfo.Split(';'))">
392+
<CreateItem Include="GitInfo" AdditionalMetadata="@(_GitCachedInfo -> TrimEnd(';'))">
393393
<Output TaskParameter="Include" ItemName="GitInfo" />
394394
</CreateItem>
395395

0 commit comments

Comments
 (0)