Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Fixup Profiler.add_global_vanilla #2494

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I had fixed this !
I guess it is due to the zero-sized subdomain test?

@FabioLuporini
Copy link
Contributor Author

no some kernels in PRO producing traffic=0, but we don't want the whole performance entry to be dropped 😬

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (f54378d) to head (5933c80).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
devito/operator/profiling.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         238      238           
  Lines       45379    45379           
  Branches     4029     4029           
=======================================
  Hits        39615    39615           
  Misses       5083     5083           
  Partials      681      681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial

@FabioLuporini FabioLuporini merged commit 78691c5 into master Dec 4, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the tweak-profiler branch December 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants