Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl: Make CondEq and CondNe easier to import #2425

Merged
merged 1 commit into from
Jul 24, 2024
Merged

dsl: Make CondEq and CondNe easier to import #2425

merged 1 commit into from
Jul 24, 2024

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Jul 24, 2024

Allow import of CondEq and CondNe from devito rather than requiring devito.symbolics. In due course, these should probably move to devito.types.relational and use the AbstractRel mixin.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (0597d00) to head (acfe740).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2425   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files         235      235           
  Lines       44750    44764   +14     
  Branches     8296     8298    +2     
=======================================
+ Hits        38796    38810   +14     
  Misses       5226     5226           
  Partials      728      728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

@FabioLuporini FabioLuporini merged commit d848426 into master Jul 24, 2024
30 of 31 checks passed
@FabioLuporini FabioLuporini deleted the condeq branch July 24, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants