compiler: Patch CSE in presence of conditionals #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 234 234
Lines 44409 44424 +15
Branches 8220 8219 -1
=======================================
+ Hits 38503 38518 +15
Misses 5185 5185
Partials 721 721 ☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
Jun 28, 2024
EdCaunt
reviewed
Jun 28, 2024
| pe, changed = _uxreplace(pe, {k: v}) | ||
| if changed and v not in scheduled: | ||
| updated.append(pe.func(v, k, operation=None)) | ||
| scheduled.append(v) | ||
| updated.append(pe) | ||
| processed = updated |
There was a problem hiding this comment.
Why not just use updated henceforth, rather than using processed?
There was a problem hiding this comment.
wdym ? we keep on looping and processed needs to be updated? what change are you proposing ?
| @@ -168,6 +168,29 @@ def test_cse_temp_order(): | |||
| assert type(args[2]) is CTemp | |||
|
|
|||
|
|
|||
| def test_cse_w_conditionals(): | |||
| grid = Grid(shape=(10, 10, 10)) | |||
| x, _, _ = grid.dimensions | |||
There was a problem hiding this comment.
Nitpick: x = grid.dimensions[0] would be tidier imo
There was a problem hiding this comment.
tidier but (nitpicking) the one above performs an implicit assertion
EdCaunt
approved these changes
Jun 28, 2024
mloubout
approved these changes
Jun 28, 2024
mloubout
approved these changes
Jun 28, 2024
mloubout
force-pushed
the
fix-cond-placement
branch
from
3f80ae9 to
90ad3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.