Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: fix printer dtype processing #2388

Merged
merged 2 commits into from
Jun 18, 2024
Merged

API: fix printer dtype processing #2388

merged 2 commits into from
Jun 18, 2024

Conversation

mloubout
Copy link
Contributor

No description provided.

@mloubout mloubout added bug-py-minor API api (symbolics, types, ...) labels Jun 18, 2024
# `same dim + same halo => same (auto-)padding`
return (d, f._size_halo[d], f.is_autopaddable)
# `same dim + same halo + same dtype => same (auto-)padding`
print(f, f.dtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (be7c403) to head (3c95932).

Files Patch % Lines
devito/types/sparse.py 40.00% 3 Missing ⚠️
devito/symbolics/printer.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
+ Coverage   86.77%   86.79%   +0.01%     
==========================================
  Files         234      234              
  Lines       44245    44265      +20     
  Branches     8181     8183       +2     
==========================================
+ Hits        38393    38418      +25     
+ Misses       5137     5124      -13     
- Partials      715      723       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout force-pushed the dtype-print branch 3 times, most recently from 7ab4c93 to d3192eb Compare June 18, 2024 14:20
@mloubout mloubout merged commit 698fdf2 into master Jun 18, 2024
31 checks passed
@mloubout mloubout deleted the dtype-print branch June 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...) bug-py-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants