Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpi: Avoid UnboundLocalVariable error #2386

Merged
merged 3 commits into from
Jun 17, 2024
Merged

mpi: Avoid UnboundLocalVariable error #2386

merged 3 commits into from
Jun 17, 2024

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (38c1709) to head (93acdf6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2386   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         234      234           
  Lines       44004    44004           
  Branches     8127     8127           
=======================================
  Hits        38204    38204           
  Misses       5093     5093           
  Partials      707      707           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the error was here, but looks like a neat edit.

@mloubout mloubout merged commit 210f899 into master Jun 17, 2024
31 checks passed
@mloubout mloubout deleted the workaround-mystery branch June 17, 2024 12:30
@FabioLuporini
Copy link
Contributor Author

Not sure what the error was here

me neither honestly

somehow triggered by PRO, maybe due to the latest Numpy 2.0 release maybe not, hard to say, but yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants