compiler: sequentialise halo touch #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 233 233
Lines 43740 43741 +1
Branches 8075 8075
=======================================
+ Hits 37952 37953 +1
Misses 5079 5079
Partials 709 709 ☔ View full report in Codecov by Sentry. |
FabioLuporini
approved these changes
May 15, 2024
| @@ -419,8 +419,10 @@ def callback(self, clusters, prefix, seen=None): | |||
|
|
|||
| key = lambda i: i in prefix[:-1] or i in hs.loc_indices | |||
| ispace = c.ispace.project(key) | |||
| # HaloTOuch are not parallel | |||
There was a problem hiding this comment.
typo (obv to fix in a future PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.