dsl: Patch edge-case derivative specifications #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
+ Coverage 78.34% 86.74% +8.39%
==========================================
Files 232 233 +1
Lines 43618 43662 +44
Branches 8073 8078 +5
==========================================
+ Hits 34174 37873 +3699
+ Misses 8684 5079 -3605
+ Partials 760 710 -50 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derivatives specified as
Derivative(f, (x, 2), (y, 0))(zeroth-order wrt one dimension) are a valid request, but the resultant derivatives were not equal to those specified asDerivative(f, (x, 2))and certain routines such as substitution would fail. This PR patches this and adds a test.