Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update tti fd for better stability #2363

Merged
merged 2 commits into from
Apr 26, 2024
Merged

examples: Update tti fd for better stability #2363

merged 2 commits into from
Apr 26, 2024

Conversation

mloubout
Copy link
Contributor

No description provided.

@mloubout mloubout added the examples examples label Apr 25, 2024
@@ -51,8 +51,8 @@ jobs:
- name: Test examples with MPI
run: |
python3 scripts/clear_devito_cache.py
DEVITO_MPI=1 mpirun -n 2 python3 -m pytest --cov --cov-config=.coveragerc --cov-report=xml examples/seismic/acoustic
DEVITO_MPI=1 mpirun -n 2 python3 -m pytest --cov --cov-config=.coveragerc --cov-report=xml examples/seismic/tti
DEVITO_MPI=1 mpirun -n 2 python3 -m pytest examples/seismic/acoustic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This doesn't really add anything to the coverage and is making codecov break all the time.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (70fe897) to head (d67b9cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
+ Coverage   78.34%   86.72%   +8.37%     
==========================================
  Files         232      232              
  Lines       43618    43622       +4     
  Branches     8073     8073              
==========================================
+ Hits        34174    37829    +3655     
+ Misses       8684     5084    -3600     
+ Partials      760      709      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mloubout mloubout merged commit 6ac1c2c into master Apr 26, 2024
31 checks passed
@mloubout mloubout deleted the tti-fd branch April 26, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants