reqs: Update cached_property to functools version #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdCaunt
force-pushed
the
cached_property
branch
from
a12e411 to
165f2f4
Compare
EdCaunt
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2359 +/- ##
==========================================
+ Coverage 86.76% 86.80% +0.04%
==========================================
Files 233 233
Lines 43764 43755 -9
Branches 8079 8078 -1
==========================================
+ Hits 37973 37983 +10
+ Misses 5080 5063 -17
+ Partials 711 709 -2 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Apr 22, 2024
devito/data/decomposition.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| from collections.abc import Iterable | |||
|
|
|||
| import numpy as np | |||
| from cached_property import cached_property | |||
| from functools import cached_property | |||
There was a problem hiding this comment.
This is now a system import so convention throughout is to group it with system import (first group with collection)
EdCaunt
force-pushed
the
cached_property
branch
2 times, most recently
from
8dad89c to
a8ab0a1
Compare
mloubout
reviewed
Apr 30, 2024
mloubout
force-pushed
the
cached_property
branch
2 times, most recently
from
e80ec62 to
bf5bf11
Compare
mloubout
approved these changes
May 21, 2024
FabioLuporini
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cached_propertyhas been included infunctoolssince Python 3.8. The originalcached_propertymodule hasn't had an update since. Since Python 3.7 is officially end-of-life, support can be dropped and we can move to usingfunctools.cached_propertythroughout the codebase. This PR updates the requirements and all imports accordingly.