Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tweak mpi setup to allow -s and hide output #2350

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

mloubout
Copy link
Contributor

Should fix @georgebisbas issue with too verbose logging for him
SHould now allow -s for embed

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.88%. Comparing base (cd836bc) to head (9de33be).

Files Patch % Lines
conftest.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2350      +/-   ##
==========================================
- Coverage   86.75%   78.88%   -7.88%     
==========================================
  Files         233      233              
  Lines       43721    43726       +5     
  Branches     8078     8080       +2     
==========================================
- Hits        37930    34493    -3437     
- Misses       5080     8468    +3388     
- Partials      711      765      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout force-pushed the mmpi-ci-v2 branch 3 times, most recently from 2c7deff to 0a003ce Compare April 15, 2024 02:57
Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the sam error locally as the one appearing in CI

@mloubout mloubout force-pushed the mmpi-ci-v2 branch 5 times, most recently from 37859c5 to d7bfcd0 Compare April 16, 2024 11:47
@mloubout mloubout force-pushed the mmpi-ci-v2 branch 2 times, most recently from 6e296b7 to 236b753 Compare April 29, 2024 22:19
Copy link
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Rip return "bonjour"

@@ -152,7 +152,7 @@ def test_interpolation_msf():
assert op1.cfunction


@pytest.mark.parallel(mode=[(1, 'diag2')])
@pytest.mark.parallel(mode=[(2, 'diag2')])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1 was fine here

@mloubout mloubout merged commit 885b365 into master Apr 30, 2024
31 checks passed
@mloubout mloubout deleted the mmpi-ci-v2 branch April 30, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPI mpi-related testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants