-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: tweak mpi setup to allow -s and hide output #2350
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
- Coverage 86.75% 78.88% -7.88%
==========================================
Files 233 233
Lines 43721 43726 +5
Branches 8078 8080 +2
==========================================
- Hits 37930 34493 -3437
- Misses 5080 8468 +3388
- Partials 711 765 +54 ☔ View full report in Codecov by Sentry. |
2c7deff
to
0a003ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the sam error locally as the one appearing in CI
37859c5
to
d7bfcd0
Compare
6e296b7
to
236b753
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Rip return "bonjour"
@@ -152,7 +152,7 @@ def test_interpolation_msf(): | |||
assert op1.cfunction | |||
|
|||
|
|||
@pytest.mark.parallel(mode=[(1, 'diag2')]) | |||
@pytest.mark.parallel(mode=[(2, 'diag2')]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 1 was fine here
Should fix @georgebisbas issue with too verbose logging for him
SHould now allow -s for embed