compiler: Tweak device-aware blocking #2348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2348 +/- ##
=======================================
Coverage 79.43% 79.44%
=======================================
Files 232 232
Lines 43571 43587 +16
Branches 8068 8070 +2
=======================================
+ Hits 34611 34627 +16
Misses 8204 8204
Partials 756 756 ☔ View full report in Codecov by Sentry. |
tests/test_dle.py
Outdated
| @@ -216,6 +217,26 @@ def test_cache_blocking_structure_optrelax_customdim(): | |||
| 'd,x0_blk0,y0_blk0,z0_blk0,x,y,z') | |||
|
|
|||
|
|
|||
| def test_cache_blocking_structure_optrelax_defaultdim_alone(): | |||
There was a problem hiding this comment.
This is a horrible test name. How about test_blocking_defaultdim_blockrelax? Failing that, give it a shorter name and add a docstring explaining what it does.
There was a problem hiding this comment.
believe it or not (check the upcoming commit time) I had already changed all those test names!
There was a problem hiding this comment.
don't check the commit time because I had to rebase to address your other comment below. So you've to do with faith this time
tests/test_dle.py
Outdated
|
|
||
| op = Operator(eqn, opt=('advanced', {'blockrelax': 'device-aware'})) | ||
|
|
||
| _, _ = assert_blocking(op, {'d0_blk0', 'x0_blk0'}) |
There was a problem hiding this comment.
Why do you need to create dummy variables here? Could you not just have assert_blocking(op, {'d0_blk0', 'x0_blk0'}) on its own?
There was a problem hiding this comment.
copy-paste leftover
No description provided.