Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_nvidia_cc to get Nvidia gpu architecture #2343

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Use get_nvidia_cc to get Nvidia gpu architecture #2343

merged 1 commit into from
Apr 3, 2024

Conversation

ggorman
Copy link
Contributor

@ggorman ggorman commented Apr 2, 2024

Use get_nvidia_cc to get Nvidia gpu architecture rather than using '-arch=native'.

This fixes compilation errors on the Nvidia Jetson.

@ggorman ggorman requested a review from FabioLuporini April 2, 2024 09:41
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.66%. Comparing base (39ea32a) to head (6e64c16).

Files Patch % Lines
devito/arch/compiler.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   86.67%   86.66%   -0.01%     
==========================================
  Files         232      232              
  Lines       43442    43445       +3     
  Branches     8062     8063       +1     
==========================================
  Hits        37653    37653              
- Misses       5084     5087       +3     
  Partials      705      705              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout
Copy link
Contributor

mloubout commented Apr 2, 2024

Commit name doesn't follow guidelines, should be

arch: Use get_nvidia_cc to get Nvidia gpu architecture ....

@mloubout mloubout added arch jitting, archinfo, ... and removed compiler labels Apr 2, 2024
…ing 'native'. This fixes compilation errors on the Nvidia Jetson.
@ggorman ggorman merged commit 311cd4e into master Apr 3, 2024
31 checks passed
@ggorman ggorman deleted the sm_cc branch April 3, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch jitting, archinfo, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants