compiler: Tweak check_stability to ensure cleanup is performed #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2335 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 232 232
Lines 43426 43442 +16
Branches 8061 8062 +1
=======================================
+ Hits 37639 37653 +14
- Misses 5082 5084 +2
Partials 705 705 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Mar 19, 2024
| if o.body.retstmt: | ||
| retval = [] | ||
| else: | ||
| retval = [c.Line(), c.Statement("return 0")] |
There was a problem hiding this comment.
Can probably be made a default retstmt but can be done alter
FabioLuporini
force-pushed
the
tweak-error-handling
branch
from
0472fee to
adc0389
Compare
mloubout
approved these changes
Mar 21, 2024
mloubout
added a commit
that referenced
this pull request
Mar 28, 2024
compiler: Tweak check_stability to ensure cleanup is performed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.