Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Enable generation of templated function declarations #2333

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, can we add a small test for it?

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.67%. Comparing base (545425a) to head (b511ffe).

Files Patch % Lines
devito/ir/iet/visitors.py 64.28% 3 Missing and 2 partials ⚠️
devito/ir/iet/efunc.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   86.68%   86.67%   -0.01%     
==========================================
  Files         232      232              
  Lines       43413    43423      +10     
  Branches     8057     8061       +4     
==========================================
+ Hits        37632    37639       +7     
- Misses       5078     5079       +1     
- Partials      703      705       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabioLuporini
Copy link
Contributor Author

a test is added is PRO (the test you've seen would fail to compile without the changes here)

but I can maybe add a simple IET test too

@FabioLuporini
Copy link
Contributor Author

@mloubout tests added

@mloubout mloubout merged commit f1d5dbf into master Mar 14, 2024
31 checks passed
@mloubout mloubout deleted the fix-partile-none branch March 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants