Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Fix custom fd for staggered #2323

Merged
merged 1 commit into from
Mar 1, 2024
Merged

api: Fix custom fd for staggered #2323

merged 1 commit into from
Mar 1, 2024

Conversation

mloubout
Copy link
Contributor

No description provided.

@mloubout mloubout added the API api (symbolics, types, ...) label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (3f3dc58) to head (30d6873).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   86.65%   86.66%           
=======================================
  Files         229      229           
  Lines       43164    43176   +12     
  Branches     8004     8004           
=======================================
+ Hits        37405    37417   +12     
  Misses       5062     5062           
  Partials      697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

except AttributeError:
assert subs is None
# assert subs is None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover, but gonna merge for now

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks !

@FabioLuporini FabioLuporini merged commit 7791956 into master Mar 1, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the stagg-fd-custom branch March 1, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants