compiler: Add Weights.value utility #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2322 +/- ##
==========================================
- Coverage 86.67% 86.66% -0.02%
==========================================
Files 229 229
Lines 43153 43164 +11
Branches 8002 8004 +2
==========================================
+ Hits 37402 37407 +5
- Misses 5054 5060 +6
Partials 697 697 ☔ View full report in Codecov by Sentry. |
| @@ -732,6 +732,24 @@ def _xreplace(self, rule): | |||
| pass | |||
| return super()._xreplace(rule) | |||
|
|
|||
| @cached_property | |||
| def _npweights(self): | |||
| # NOTE: `self.weights` cannot just be an array or SymPy will fail | |||
There was a problem hiding this comment.
Break into two sentences? Reads a bit weird
There was a problem hiding this comment.
will do in nxt pr
EdCaunt
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.