compiler: Hotfix unevaluation.Pow(1, ...) #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
==========================================
- Coverage 86.67% 86.67% -0.01%
==========================================
Files 229 229
Lines 43150 43153 +3
Branches 8001 8002 +1
==========================================
+ Hits 37401 37402 +1
- Misses 5053 5054 +1
- Partials 696 697 +1 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Feb 26, 2024
|
Uncontroversial |
georgebisbas
approved these changes
Feb 26, 2024
EdCaunt
reviewed
Feb 26, 2024
| # such as `1**c` | ||
| return sympy.S.One | ||
| else: | ||
| return cls.__base__.__new__(cls, base, exp, evaluate=False, **kwargs) |
There was a problem hiding this comment.
Do you not want to pass the kwarg evaluate through here? It's currently not getting used
There was a problem hiding this comment.
No we want to force not to evaluate we do it in a bunch of place and it's easier like that to separate it from the kwargs
There was a problem hiding this comment.
Mathias is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.