Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update MPI notebook to reference inner and outer halo terminology #2319

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Feb 22, 2024

No description provided.

@EdCaunt EdCaunt requested a review from georgebisbas February 22, 2024 10:34
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EdCaunt EdCaunt added the examples examples label Feb 22, 2024
@EdCaunt EdCaunt self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (2f27c9d) to head (bd88230).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2319   +/-   ##
=======================================
  Coverage   86.67%   86.68%           
=======================================
  Files         229      229           
  Lines       43107    43150   +43     
  Branches     7996     8001    +5     
=======================================
+ Hits        37365    37403   +38     
- Misses       5048     5051    +3     
- Partials      694      696    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see some deleted text? Is that the purpose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, looks like a flaky commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird. Not sure what happened there. Will fix

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, GTG

@FabioLuporini FabioLuporini merged commit 0dbe9c1 into master Feb 28, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the halo_notebook branch February 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants