compiler: Block reductions irrespective of par-tile #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
- Coverage 86.71% 86.69% -0.03%
==========================================
Files 229 229
Lines 42958 42978 +20
Branches 7958 7966 +8
==========================================
+ Hits 37251 37259 +8
- Misses 5023 5032 +9
- Partials 684 687 +3 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Feb 12, 2024
| # See also issue #276:PRO | ||
| if any(c.properties.is_parallel_atomic(d) for c in clusters): | ||
| if any(c.is_sparse for c in clusters): | ||
| if not x: |
There was a problem hiding this comment.
Don't think you don't need this, it's just a tuple not a multi-tuple, same below
There was a problem hiding this comment.
Wait no you do need it to go back to first element if there is multiple sparse/reduce cluster nevermind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in PRO
I also took the chance to create opt-options to allow specifying different par-tiles for reduction loops