mpi: Add basic2 mode #2307

georgebisbas · 2024-02-10T18:11:54Z

Preallocated buffers using MPIMsg.
An MPIMsgEnriched version for send/recv, will follow

codecov · 2024-02-10T18:18:27Z

Codecov Report

Attention: Patch coverage is 98.14815% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (41d04ed) to head (28825e1).

Files with missing lines	Patch %	Lines
devito/mpi/routines.py	98.03%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2307    +/-   ##
========================================
  Coverage   87.29%   87.29%            
========================================
  Files         238      238            
  Lines       45382    45510   +128     
  Branches     4031     4049    +18     
========================================
+ Hits        39616    39729   +113     
- Misses       5083     5096    +13     
- Partials      683      685     +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devito/mpi/routines.py

FabioLuporini · 2024-02-21T11:23:33Z

devito/mpi/routines.py

+
+        return SendRecv('sendrecv%s' % key, iet, parameters, bufg, bufs)
+
+    def _call_sendrecv(self, name, *args, msg=None, haloid=None):


why do you need a haloid here ? never had to use it. What makes this mode require it?

Similarly to the same method in OverlapHalo. Each call to sendrecv has its own message indexedpointer

devito/mpi/routines.py

FabioLuporini · 2024-02-21T11:29:48Z

devito/mpi/routines.py

+            mapper[(d0, side, region)] = (sizes)
+
+        i = 0
+        for d in f.dimensions:


why not :

for i, halo in enumerate(self.halos):

like we have in the other message types?

I followed the basic style, which does not have yet a method to cleanup the redundant halos as in diag2 for example:
e.g.:

# Only retain the halos required by the Diag scheme halos = sorted(i for i in hse.halos if isinstance(i.dim, tuple))

I tried this but did not manage to get it working nicely.

FabioLuporini · 2024-04-04T12:39:56Z

tests/test_mpi.py

@@ -801,7 +801,7 @@ def test_trivial_eq_2d(self):
            assert np.all(f.data_ro_domain[0, :-1, -1:] == side)
            assert np.all(f.data_ro_domain[0, -1:, :-1] == side)

-    @pytest.mark.parallel(mode=[(8, 'basic'), (8, 'diag'), (8, 'overlap'),
+    @pytest.mark.parallel(mode=[(8, 'basic'), (8, 'basic2'), (8, 'diag'), (8, 'overlap'),


I would drop basic here and below... or overlap perhaps. These tests can be quite expensive

EdCaunt · 2024-08-01T18:26:56Z

devito/mpi/routines.py

@@ -1185,6 +1297,16 @@ def _as_number(self, v, args):
            assert args is not None
            return int(subs_op_args(v, args))

+    def _allocate_buffers(self, f, shape, entry):


This could use some whitespace to make it more readable

agree, added a docstring as well

EdCaunt · 2024-08-01T18:33:02Z

devito/mpi/routines.py

+            if d in fixed:
+                continue
+
+            if (d, LEFT) in self.halos:


for side in (LEFT, RIGHT): if (d, side) in self.halos: entry = self.value[i] i += 1 shape = mapper[(d, side, OWNED)] self._allocate_buffers(f, shape, entry)

fixed, thanks

EdCaunt

Is documentation required somewhere to explain what the new Basic2 mode does?

EdCaunt · 2024-11-18T11:29:35Z

devito/mpi/routines.py

+            if d in fixed:
+                continue
+
+            name = ''.join('r' if i is d else 'c' for i in distributor.dimensions)


Nitpick: lname and rname would be preferable to overwriting name imo

agree, thanks!

mpi: Drop redundant determinism

georgebisbas added the MPI mpi-related label Feb 10, 2024

georgebisbas requested review from FabioLuporini and mloubout February 10, 2024 18:11

georgebisbas self-assigned this Feb 10, 2024

georgebisbas force-pushed the basic2mpi branch from 024e82b to b4e67e3 Compare February 10, 2024 18:13

georgebisbas closed this Feb 10, 2024

georgebisbas reopened this Feb 10, 2024

georgebisbas marked this pull request as draft February 10, 2024 18:14

georgebisbas force-pushed the basic2mpi branch from befd078 to 89387c8 Compare February 12, 2024 20:31

EdCaunt reviewed Feb 14, 2024

View reviewed changes

devito/mpi/routines.py Show resolved Hide resolved

georgebisbas force-pushed the basic2mpi branch 4 times, most recently from ff919e2 to 895cef3 Compare February 16, 2024 18:40

georgebisbas marked this pull request as ready for review February 16, 2024 18:55

georgebisbas requested a review from EdCaunt February 16, 2024 18:55

georgebisbas force-pushed the basic2mpi branch from 895cef3 to 51411cc Compare February 19, 2024 17:21

FabioLuporini reviewed Feb 20, 2024

View reviewed changes

devito/mpi/routines.py Outdated Show resolved Hide resolved

FabioLuporini reviewed Feb 21, 2024

View reviewed changes

georgebisbas force-pushed the basic2mpi branch from 51411cc to 6a0ce49 Compare February 22, 2024 13:07

georgebisbas requested a review from FabioLuporini February 22, 2024 13:07

georgebisbas force-pushed the basic2mpi branch from 6a0ce49 to 7d206db Compare February 27, 2024 15:50

georgebisbas force-pushed the basic2mpi branch from 7d206db to 12c9fed Compare March 20, 2024 16:37

georgebisbas force-pushed the basic2mpi branch from 12c9fed to 23a0ce8 Compare April 3, 2024 15:37

FabioLuporini reviewed Apr 4, 2024

View reviewed changes

georgebisbas force-pushed the basic2mpi branch 4 times, most recently from 5a5e826 to c266e14 Compare April 9, 2024 17:35

georgebisbas force-pushed the basic2mpi branch 2 times, most recently from e849e40 to 55b11d5 Compare May 9, 2024 16:36

georgebisbas force-pushed the basic2mpi branch from 55b11d5 to 55b3706 Compare May 27, 2024 15:55

georgebisbas force-pushed the basic2mpi branch from 55b3706 to 3ac5fef Compare July 31, 2024 14:27

EdCaunt reviewed Aug 1, 2024

View reviewed changes

georgebisbas force-pushed the basic2mpi branch from 58dbb96 to dab37fd Compare September 24, 2024 14:42

georgebisbas force-pushed the basic2mpi branch from dab37fd to 12f133c Compare November 14, 2024 17:45

EdCaunt reviewed Nov 18, 2024

View reviewed changes

georgebisbas added 11 commits December 10, 2024 12:48

mpi: Adjoint failing, rest passign

fcd4d1c

mpi: Merge halowait and haloupdate

9d89a0f

mpi: drop redundant make_halowait

0dabcf9

mpi: Add Base Class for MPIMsg, and drop redundant

df3577f

mpi: Drop redundant code, come cleanup

2cb6d37

tests: Reinstate testing parameters for adjoint

dec3c1d

mpi: Add _allocate_buffers, make_basic_mapper

aab6509

mpi: Drop redundant determinism

mpi: Address reviews

7014fd0

mpi: drop basic tests

2205a3a

tests: Update tests after rebase on #2347

9f248a2

compiler: Restore macros ordering after rebase

c6b6a42

georgebisbas force-pushed the basic2mpi branch from 12f133c to 01ed5e2 Compare December 10, 2024 12:48

compiler: Reduce some code after reviews

28825e1

georgebisbas force-pushed the basic2mpi branch from 01ed5e2 to 28825e1 Compare December 10, 2024 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mpi: Add basic2 mode #2307

mpi: Add basic2 mode #2307

georgebisbas commented Feb 10, 2024

codecov bot commented Feb 10, 2024 •

edited

Loading

FabioLuporini Feb 21, 2024

georgebisbas Feb 22, 2024

FabioLuporini Feb 21, 2024

georgebisbas Feb 22, 2024

FabioLuporini Apr 4, 2024

EdCaunt Aug 1, 2024

georgebisbas Dec 10, 2024

EdCaunt Aug 1, 2024

georgebisbas Dec 10, 2024

EdCaunt left a comment

EdCaunt Nov 18, 2024

georgebisbas Dec 10, 2024


		return SendRecv('sendrecv%s' % key, iet, parameters, bufg, bufs)

		def _call_sendrecv(self, name, *args, msg=None, haloid=None):

mpi: Add basic2 mode #2307

Are you sure you want to change the base?

mpi: Add basic2 mode #2307

Conversation

georgebisbas commented Feb 10, 2024

codecov bot commented Feb 10, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EdCaunt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Feb 10, 2024 •

edited

Loading