compiler: Adjust names used for cire-rotate dimensions #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2305 +/- ##
=======================================
Coverage 86.69% 86.70%
=======================================
Files 229 229
Lines 43043 43043
Branches 7983 7983
=======================================
+ Hits 37318 37320 +2
+ Misses 5034 5032 -2
Partials 691 691 ☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
FabioLuporini
approved these changes
Feb 12, 2024
mloubout
approved these changes
Feb 12, 2024
mloubout
force-pushed
the
cire_dim_names
branch
from
e83e6b7 to
d216ead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubDimensions with long names produce ugly iteration variables in the generated C when combined withcire-rotatedue to a naming convention that repeats the dimension name. This PR introduces a shorter naming convention.