arch: patch compiler version #2297
Merged
+24
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devito/arch/compiler.py
Outdated
| try: | ||
| # Knowing the version may still be useful to pick supported flags | ||
| version = sniff_compiler_version(self.CC) | ||
| except (FileNotFoundError, OSError): |
There was a problem hiding this comment.
in case of FileNotFoundError a sys.exit() will be called inside sniff_compiler_version and the program will abort, so we might have to tweak that too
There was a problem hiding this comment.
or we just remove this try-except and wait for the next use case to break
There was a problem hiding this comment.
Changed to something bit simpler
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
- Coverage 86.75% 86.74% -0.01%
==========================================
Files 229 229
Lines 42898 42905 +7
Branches 7955 7957 +2
==========================================
+ Hits 37215 37217 +2
- Misses 5007 5012 +5
Partials 676 676 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
custom-comp-ver
branch
from
d70bda2 to
81372ec
Compare
mloubout
force-pushed
the
custom-comp-ver
branch
from
81372ec to
e621833
Compare
FabioLuporini
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.