api: Fix gpu-fit for TensorFunction #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
gpufit-tensor
branch
from
66a42db to
1b5f035
Compare
tests/test_gpu_common.py
Outdated
| @@ -1442,6 +1442,18 @@ def test_pickling(self): | |||
|
|
|||
| assert str(op) == str(new_op) | |||
|
|
|||
| def test_tensor_fit(self): | |||
There was a problem hiding this comment.
There's a TestAPI class in this file I'd move it there and spell it out test_gpu_fit_w_tensor_functions
(Spelling it out helps in absence of docstrings)
mloubout
force-pushed
the
gpufit-tensor
branch
from
1b5f035 to
dbd0064
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
- Coverage 86.86% 86.84% -0.03%
==========================================
Files 229 229
Lines 42535 42548 +13
Branches 7892 7893 +1
==========================================
+ Hits 36949 36951 +2
- Misses 4929 4940 +11
Partials 657 657 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.