compiler: Fix handling of redundant derivatives #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
+ Coverage 86.84% 86.85% +0.01%
==========================================
Files 229 229
Lines 42548 42579 +31
Branches 7893 7900 +7
==========================================
+ Hits 36951 36984 +33
+ Misses 4940 4939 -1
+ Partials 657 656 -1 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Dec 18, 2023
| def _(expr, estimate): | ||
| flops, _ = _estimate_cost(expr.expr, estimate) | ||
| @dont_count_if_seen | ||
| def _(expr, estimate, seen): |
There was a problem hiding this comment.
Should this be also done for EvalDerivative to catch prematurely evaluated derivs?
There was a problem hiding this comment.
unnecessary
EvalDerivatives are Adds so they will be treated as such. EvalDerivatives are lower-level, more rudimentary objects, so it's OK to be treated as such
FabioLuporini
force-pushed
the
fix-estimate-cost
branch
from
006ede8 to
8f50425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.