compiler: Check DeviceFunctions for SubDimensions #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2279 +/- ##
==========================================
- Coverage 86.82% 86.82% -0.01%
==========================================
Files 229 229
Lines 42441 42450 +9
Branches 7868 7870 +2
==========================================
+ Hits 36851 36858 +7
- Misses 4931 4933 +2
Partials 659 659 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Dec 8, 2023
devito/passes/iet/misc.py
Outdated
| if d.root not in dimensions | ||
| and names.count(d.root.name) < 2} | ||
|
|
||
| if isinstance(iet, DeviceFunction): |
There was a problem hiding this comment.
Might be better off lifting out rename_subdims and single dispatch on iet
There was a problem hiding this comment.
I agree
You may call it _abridge_subdim_names should we ever wanted to extend abdridging with more sort of objects (or use it to rename Temps such that they appear in order, for example)
I also agree we need singledispatch here
mloubout
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight improvement to the coverage of
abridge_dim_namesas a couple of things were getting missed.