MPI: Fix sparse subfunction handling when used without parent #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
- Coverage 86.83% 86.80% -0.03%
==========================================
Files 229 229
Lines 42464 42516 +52
Branches 7876 7889 +13
==========================================
+ Hits 36872 36908 +36
- Misses 4939 4952 +13
- Partials 653 656 +3 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
rotfd
branch
4 times, most recently
from
cbded3b to
b8687ce
Compare
mloubout
force-pushed
the
rotfd
branch
5 times, most recently
from
3f5c5aa to
030e0b6
Compare
FabioLuporini
approved these changes
Dec 13, 2023
devito/types/sparse.py
Outdated
| loc_shape = [] | ||
| assert len(dimensions) == len(shape) | ||
| for i, (d, s) in enumerate(zip(dimensions, shape)): | ||
| if i is cls._sparse_position: |
There was a problem hiding this comment.
intergers want == , though ininfluential here
devito/types/sparse.py
Outdated
| @@ -174,6 +191,7 @@ def _comm(self): | |||
|
|
|||
| @property | |||
| def _coords_indices(self): | |||
| # Assume integer dtypemeans gridpioints | |||
georgebisbas
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus minor generic cleanup/tweaks
Fixes #2277