Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: prevent derivative shortcut with incompatible fd order #2254

Merged
merged 2 commits into from
Oct 31, 2023
Merged

api: prevent derivative shortcut with incompatible fd order #2254

merged 2 commits into from
Oct 31, 2023

Conversation

mloubout
Copy link
Contributor

No description provided.

@mloubout mloubout added the API api (symbolics, types, ...) label Oct 31, 2023
@mloubout mloubout mentioned this pull request Oct 31, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #2254 (e6ca17e) into master (d4ebfa9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
+ Coverage   86.94%   86.95%   +0.01%     
==========================================
  Files         229      229              
  Lines       41825    41845      +20     
  Branches     7719     7723       +4     
==========================================
+ Hits        36364    36386      +22     
+ Misses       4834     4827       -7     
- Partials      627      632       +5
Files Coverage Δ
devito/finite_differences/differentiable.py 94.20% <100.00%> (+0.07%) ⬆️
devito/ir/clusters/cluster.py 93.33% <100.00%> (ø)
tests/test_derivatives.py 100.00% <100.00%> (ø)
tests/test_lower_exprs.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

FabioLuporini
FabioLuporini approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial, thx

@mloubout mloubout force-pushed the fix-fd-shct branch 2 times, most recently from f00e0d4 to a6899fa Compare October 31, 2023 17:17
@mloubout mloubout merged commit 8e33092 into master Oct 31, 2023
32 checks passed
@mloubout mloubout deleted the fix-fd-shct branch November 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgebisbas georgebisbas georgebisbas approved these changes

@FabioLuporini FabioLuporini FabioLuporini approved these changes

Assignees
No one assigned
Labels
API api (symbolics, types, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mloubout @FabioLuporini @georgebisbas