Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Fix unexpansion w custom coeffs #2242

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2242 (d62b080) into master (dd1b154) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #2242   +/-   ##
=======================================
  Coverage   86.90%   86.91%           
=======================================
  Files         229      229           
  Lines       41545    41568   +23     
  Branches     7660     7666    +6     
=======================================
+ Hits        36105    36128   +23     
+ Misses       4818     4817    -1     
- Partials      622      623    +1     
Files Coverage Δ
devito/finite_differences/coefficients.py 93.12% <100.00%> (+0.16%) ⬆️
tests/test_unexpansion.py 100.00% <100.00%> (ø)
devito/finite_differences/differentiable.py 93.90% <83.33%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xreplace missing flag, except that gtg

@@ -637,6 +637,15 @@ def spacings(self):

weights = Array.initvalue

def _xreplace(self, rule):
if self in rule:
return rule[self]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, true

Same below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Pushed fix

@FabioLuporini FabioLuporini force-pushed the fix-unexp-w-sym-coeffs branch from 1d26ace to b04c9cc Compare October 20, 2023 14:47
@FabioLuporini FabioLuporini force-pushed the fix-unexp-w-sym-coeffs branch from b04c9cc to d62b080 Compare October 20, 2023 16:01
@mloubout mloubout merged commit c7d542f into master Oct 21, 2023
32 checks passed
@mloubout mloubout deleted the fix-unexp-w-sym-coeffs branch October 21, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants