compiler: prevent multisubdimension expressions duplicates #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
force-pushed
the
msd-pass-fix
branch
2 times, most recently
from
3a33044 to
6f4453e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
- Coverage 87.04% 87.04% -0.01%
==========================================
Files 229 229
Lines 40930 40935 +5
Branches 7492 7493 +1
==========================================
+ Hits 35627 35631 +4
Misses 4692 4692
- Partials 611 612 +1
|
mloubout
force-pushed
the
msd-pass-fix
branch
from
6f4453e to
67d8a26
Compare
FabioLuporini
approved these changes
Oct 12, 2023
| @@ -106,6 +107,13 @@ def callback(self, clusters, prefix): | |||
| # The "implicit expressions" created for the MultiSubDomain | |||
| exprs, dims, sub_iterators = make_implicit_exprs(d.msd, c) | |||
|
|
|||
| # Make sure the "implicit expressions" aren't scheduled in | |||
| # an inner loop. E.g schedule both for `t, xi, yi` and `t, d, xi, yi` | |||
There was a problem hiding this comment.
what do you mean by "both" here?
I think the example could be a bit more clear here
OK in another PR
There was a problem hiding this comment.
For clusters with itspace t, xi, yi and t, d, xi, yi then this statement will be reached twice during the self.process once for t as a prefix and once for t, d
mloubout
force-pushed
the
msd-pass-fix
branch
from
67d8a26 to
311f377
Compare
mloubout
force-pushed
the
msd-pass-fix
branch
from
311f377 to
b3b85e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't easily make a test for it here. Breaks
aboxwith extra dims