compiler: prevent reduction clause for perfect-enough outer loops #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.03%
==========================================
Files 228 228
Lines 40859 40919 +60
Branches 7482 7490 +8
==========================================
+ Hits 35573 35616 +43
- Misses 4676 4692 +16
- Partials 610 611 +1
|
mloubout
force-pushed
the
reduction-atimic
branch
4 times, most recently
from
9b8ecc8 to
d628f54
Compare
georgebisbas
approved these changes
Oct 9, 2023
devito/passes/iet/parpragma.py
Outdated
| @@ -318,6 +318,16 @@ def _make_reductions(self, partree): | |||
| if not any(i.is_ParallelAtomic for i in partree.collapsed): | |||
| return partree | |||
|
|
|||
| # We bypass the corner case where a reduction might not be optimal, mainly: | |||
| # - Only the most inner loop is atomic | |||
FabioLuporini
approved these changes
Oct 10, 2023
FabioLuporini
force-pushed
the
reduction-atimic
branch
from
5469672 to
a70fafb
Compare
mloubout
force-pushed
the
reduction-atimic
branch
from
52d441c to
c26228d
Compare
mloubout
force-pushed
the
reduction-atimic
branch
from
c26228d to
daf671c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2224 . Added MFE as tests to CPU and GPU
This is not a full generalized fix, the dependency analysis still needs some work to detect some patterns than can be optimized such as
[noatomic, atomic, noatomic]that should be lowered toparallel, nothing, simd]