compiler: Fix issue 2194 #2212
Merged
compiler: Fix issue 2194 #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
=======================================
Coverage 87.10% 87.11%
=======================================
Files 228 228
Lines 40783 40810 +27
Branches 7465 7471 +6
=======================================
+ Hits 35525 35551 +26
Misses 4653 4653
- Partials 605 606 +1
|
mloubout
approved these changes
Sep 20, 2023
FabioLuporini
requested changes
Sep 21, 2023
devito/ir/support/basic.py
Outdated
|
|
||
| # Writing (reading) over an entire dimension, reading (writing) | ||
| # from one point | ||
|
|
There was a problem hiding this comment.
nitpicking, I wouldn't normally say it, but since this is your learning phase and since this might be the first of many PRs... :
- Drop blank line;
- Move the "For example ..." on the same line as "# from one point. For example:" (after the for example, it's ok to break line)
There was a problem hiding this comment.
In doing this, please git rebase and squash
AndrewCheng827
force-pushed
the
Andrew_fix_2194
branch
3 times, most recently
from
782463b to
47a39ea
Compare
mloubout
force-pushed
the
Andrew_fix_2194
branch
2 times, most recently
from
27bf8bf to
1a11d18
Compare
mloubout
force-pushed
the
Andrew_fix_2194
branch
from
1a11d18 to
c3abf22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.