api: Cleanup and improve SubFunction #2198
Conversation
mloubout
force-pushed
the
drop-sf-parent
branch
from
3fd6595 to
74a92ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 228 228
Lines 40579 40611 +32
Branches 7419 7429 +10
=======================================
+ Hits 35337 35367 +30
- Misses 4642 4644 +2
Partials 600 600
... and 1 file with indirect coverage changes 📢 Have feedback on the report? Share it here. |
mloubout
force-pushed
the
drop-sf-parent
branch
6 times, most recently
from
729b68e to
5fb05ab
Compare
| for k, v in w_funcs.items()]) | ||
| except AttributeError: | ||
| assert w_funcs == 0 | ||
| if len(w_funcs) > 1: |
There was a problem hiding this comment.
@FabioLuporini this does not fix the pickle reconstruction issue with (-1)* so left the _print_Mul in printer for the time being.
There was a problem hiding this comment.
OK. Can you open an issue about that and refer to the failing test without the hack?
|
|
||
| expr = sf.inject(m, Float(1.)) | ||
| sf.data.fill(1.) | ||
| expr = sf.inject(m, sf) |
There was a problem hiding this comment.
This one is actually a consequence of removing parent as injecting 1 akes an operator that does not process sf anymore as an argument as it was only processed through the coordinates as a parent
mloubout
force-pushed
the
drop-sf-parent
branch
from
5fb05ab to
2a3654b
Compare
| for k, v in w_funcs.items()]) | ||
| except AttributeError: | ||
| assert w_funcs == 0 | ||
| if len(w_funcs) > 1: |
There was a problem hiding this comment.
OK. Can you open an issue about that and refer to the failing test without the hack?
mloubout
force-pushed
the
drop-sf-parent
branch
from
2a3654b to
68c29d4
Compare
Fixes #2192
subs/rebuildof SparseFunction to properly propagate through the subfunctions (coords, ...)