Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ.md #2195

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Update FAQ.md #2195

merged 3 commits into from
Oct 11, 2023

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

FAQ.md Outdated

With a device PLATFORM (e.g., `nvidiaX` or `amdgpuX`), the compiler will generate OpenMP code for device offloading.

When using OpenMP offloading, it is however recommended to stick to the corresponding vendor compiler, so `ARCH=amdclang` for AMD, `ARCH={icc,icx,intel}` for Intel, and `ARCH=nvc` for NVidia.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note that icx is the default when using intel?
and ICC gonna be deprecated?

FAQ.md Outdated

Requires: `PLATFORM=nvidiaX` and `ARCH=cuda`.

Also requires DevitoPRO.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available only with a DevitoPRO license ?

... or drop "also"

FAQ.md Outdated

Requires: `PLATFORM=amdgpuX` and `ARCH=hip`.

Also requires DevitoPRO.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Also requires DevitoPRO.


[top](#Frequently-Asked-Questions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what line 303 pointed to

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2195 (9875557) into master (7763d03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2195   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         228      228           
  Lines       40299    40299           
  Branches     7357     7357           
=======================================
  Hits        35088    35088           
  Misses       4625     4625           
  Partials      586      586           

FAQ.md Outdated

#### LANGUAGE=openacc

Recommended: `PLATFORM=nvidiaX` and `ARCH=nvc`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLATFORM=nvidiaX is required here not recommended

@mloubout
Copy link
Contributor

GTG no?

@@ -244,26 +246,6 @@ These environment variables can either be set from the shell or programmatically
| programmatically | configuration['language'] = 'openmp' |


### Table of values for Devito environment variables
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed as obsolete and unmaintanable

replaced suggesting the user to execute print_defaults instead ( a few lines above)

@FabioLuporini
Copy link
Contributor Author

Now patched as per suggestions. Plus a few other tweaks. Merging

@FabioLuporini FabioLuporini merged commit 7b5332a into master Oct 11, 2023
31 checks passed
@FabioLuporini FabioLuporini deleted the update-faq-1 branch October 11, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants