api: fix symbolic coeffs for cross derivatives #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 226 226
Lines 40183 40197 +14
Branches 7333 7335 +2
=======================================
+ Hits 35000 35014 +14
Misses 4603 4603
Partials 580 580
|
georgebisbas
approved these changes
Aug 10, 2023
|
|
||
| for j in range(len(coeffs)): | ||
| subs.update({function._coeff_symbol | ||
| (indices[j], deriv_order, function, index): coeffs[j]}) | ||
|
|
||
| # Set all unused weights to zero | ||
| for w in sweights: |
There was a problem hiding this comment.
cleaner:
subs.update({w: 0 for w in sweights if w not in subs})
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explanatory